Skip to content

Allow trimming away ScopedRefAttribute. #72814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2022
Merged

Allow trimming away ScopedRefAttribute. #72814

merged 1 commit into from
Aug 5, 2022

Conversation

@teo-tsirpanis
Copy link
Contributor

@teo-tsirpanis teo-tsirpanis commented Jul 25, 2022

@ghost
Copy link

ghost commented Jul 25, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added linkable-framework Issues associated with delivering a linker friendly framework community-contribution Indicates that the PR has been added by a community member labels Jul 25, 2022
@ghost
Copy link

ghost commented Jul 25, 2022

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr
See info in area-owners.md if you want to be subscribed.

Issue Details

Ref: dotnet/roslyn#62838.

Author: teo-tsirpanis
Assignees: -
Labels:

linkable-framework
Milestone: -

stephentoub
stephentoub approved these changes Jul 26, 2022
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but let's wait until the roslyn change is merged.

@stephentoub stephentoub added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Jul 26, 2022
@AaronRobinsonMSFT
Copy link
Member

AaronRobinsonMSFT commented Jul 26, 2022

If we are trimming away ScopedRefAttribute, what about UnscopedRefAttribute?

@teo-tsirpanis
Copy link
Contributor Author

teo-tsirpanis commented Jul 26, 2022 •
edited
Loading

Handled in #72678. Maybe me saying that "Just saw that it will be synthesized by Roslyn." in #72678 (comment) was misunderstood that trimming ScopedRefAttribute is not needed.

@karelz karelz mentioned this pull request Aug 1, 2022
Open
@teo-tsirpanis
Copy link
Contributor Author

teo-tsirpanis commented Aug 3, 2022

@stephentoub, dotnet/roslyn#63009 has been merged. Can we merge this?

@stephentoub stephentoub removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Aug 5, 2022
@AaronRobinsonMSFT AaronRobinsonMSFT merged commit bf56a7c into dotnet:main Aug 5, 2022
@teo-tsirpanis teo-tsirpanis deleted the patch-1 branch August 5, 2022 08:52
@ghost ghost locked as resolved and limited conversation to collaborators Sep 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoub stephentoub stephentoub approved these changes

Assignees

No one assigned

Labels

community-contribution Indicates that the PR has been added by a community member linkable-framework Issues associated with delivering a linker friendly framework

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@teo-tsirpanis @AaronRobinsonMSFT @stephentoub