Skip to content

HTTP/3 Made alt-used show only on alt-svc redirect #72669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 28, 2022
Merged

HTTP/3 Made alt-used show only on alt-svc redirect #72669

merged 8 commits into from
Jul 28, 2022

Conversation

iuliaco
Copy link
Contributor

@iuliaco iuliaco commented Jul 22, 2022

Fixes #56876
I only did a test for checking not alt-used included, tests which include checking alt-used header are already implemented here.

@ghost ghost added area-System.Net.Http community-contribution Indicates that the PR has been added by a community member labels Jul 22, 2022
@ghost
Copy link

ghost commented Jul 22, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #56876
I only did a test for checking not alt-used included, tests which include checking alt-used header are already implemented here.

Author: iuliaco
Assignees: -
Labels:

area-System.Net.Http
Milestone: -

@ManickaP ManickaP requested a review from a team July 22, 2022 11:08
@ManickaP ManickaP removed the community-contribution Indicates that the PR has been added by a community member label Jul 22, 2022
CarnaViire
CarnaViire approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@CarnaViire CarnaViire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo nits, thanks!

iuliaco and others added 2 commits July 27, 2022 10:39
@iuliaco @CarnaViire
Update src/libraries/System.Net.Http/tests/FunctionalTests/HttpClient…
06f518b 
…HandlerTest.Http3.cs

Co-authored-by: Natalia Kondratyeva <knatalia@microsoft.com>
@iuliaco @CarnaViire
Update src/libraries/System.Net.Http/tests/FunctionalTests/HttpClient…
fd2c65c 
…HandlerTest.Http3.cs

Co-authored-by: Natalia Kondratyeva <knatalia@microsoft.com>
@runfoapp runfoapp bot mentioned this pull request Jul 27, 2022
Closed
@CarnaViire
Copy link
Member

@iuliaco could you please update your branch to the current main (because #72854 is merged now), so we could rerun the tests in CI without Http tests being timed out

@runfoapp runfoapp bot mentioned this pull request Jul 27, 2022
Closed
@iuliaco
Copy link
Contributor Author

iuliaco commented Jul 28, 2022

Done

@CarnaViire CarnaViire merged commit 812ad81 into dotnet:main Jul 28, 2022
@karelz karelz added this to the 7.0.0 milestone Aug 7, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ManickaP ManickaP ManickaP left review comments

@CarnaViire CarnaViire CarnaViire approved these changes

Assignees
No one assigned
Labels
area-System.Net.Http
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

Http/3 adds alt-used header even when alt-svc isn't is used
4 participants
@iuliaco @CarnaViire @ManickaP @karelz