Add analyzer support to validate the stateless marshaller shapes #72643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for validating the stateful shapes and for providing the code-fix to add the missing members is left for a future PR to try to keep the size on this one down at least a little bit.
…ArrayMarshaller/PointerArrayMarshaller
jkoritzinsky
added
area-System.Runtime.InteropServices
source-generator
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsSupport for validating the stateful shapes and for providing the code-fix to add the missing members is left for a future PR to try to keep the size on this one down at least a little bit. Fixes #72622 (comment) (verified by turning on AD0001 diagnostic locally and making sure that none of the libraries build emits it)
|
…alyzer against CoreLib discovered
jkoritzinsky
force-pushed
the
shape-method-analyzer
branch
from
f53fd48 to
a031bd4
Compare
elinor-fung
reviewed
Jul 23, 2022
...s/System.Runtime.InteropServices/gen/LibraryImportGenerator/Analyzers/AnalyzerDiagnostics.cs
Show resolved
Hide resolved
...me.InteropServices/gen/LibraryImportGenerator/Analyzers/CustomMarshallerAttributeAnalyzer.cs
Outdated
Show resolved
Hide resolved
...me.InteropServices/gen/LibraryImportGenerator/Analyzers/CustomMarshallerAttributeAnalyzer.cs
Show resolved
Hide resolved
...me.InteropServices/gen/LibraryImportGenerator/Analyzers/CustomMarshallerAttributeAnalyzer.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime.InteropServices/gen/LibraryImportGenerator/Resources/Strings.resx
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime.InteropServices/gen/LibraryImportGenerator/Resources/Strings.resx
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime.InteropServices/gen/LibraryImportGenerator/Resources/Strings.resx
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime.InteropServices/gen/LibraryImportGenerator/Resources/Strings.resx
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime.InteropServices/gen/LibraryImportGenerator/Resources/Strings.resx
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime.InteropServices/gen/LibraryImportGenerator/Resources/Strings.resx
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime.InteropServices/gen/LibraryImportGenerator/Resources/Strings.resx
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime.InteropServices/gen/LibraryImportGenerator/Resources/Strings.resx
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime.InteropServices/gen/LibraryImportGenerator/Resources/Strings.resx
Outdated
Show resolved
Hide resolved
...ystem.Runtime.InteropServices/gen/Microsoft.Interop.SourceGeneration/TypeSymbolExtensions.cs
Show resolved
Hide resolved
...me.InteropServices/gen/LibraryImportGenerator/Analyzers/CustomMarshallerAttributeAnalyzer.cs
Outdated
Show resolved
Hide resolved
elinor-fung
approved these changes
Jul 26, 2022
src/libraries/System.Runtime.InteropServices/gen/LibraryImportGenerator/Resources/Strings.resx
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime.InteropServices/gen/LibraryImportGenerator/Resources/Strings.resx
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for validating the stateful shapes and for providing the code-fix to add the missing members is left for a future PR to try to keep the size on this one down at least a little bit.
Fixes #72622 (comment) (verified by turning on AD0001 diagnostic locally and making sure that none of the libraries build emits it)