Skip to content

[wasm] bump npm packages, fix lint errors #72600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 21, 2022

Conversation

pavelsavara
Copy link
Member

Bit broader than #72528

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-Build-mono labels Jul 21, 2022
@pavelsavara pavelsavara added this to the 7.0.0 milestone Jul 21, 2022
@pavelsavara pavelsavara requested a review from radekdoulik July 21, 2022 12:45
@pavelsavara pavelsavara self-assigned this Jul 21, 2022
@pavelsavara pavelsavara requested a review from lewing as a code owner July 21, 2022 12:45
@ghost
Copy link

ghost commented Jul 21, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Bit broader than #72528

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-Build-mono

Milestone: 7.0.0

@pavelsavara
Copy link
Member Author

npm ci died with

  npm ERR! code E401
  npm ERR! Unable to authenticate, your authentication token seems to be invalid.
  npm ERR! To correct this please trying logging in again with:
  npm ERR!     npm login

It's probably related to src\mono\wasm\runtime\.npmrc pointing to https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public-npm/npm/registry/

But anyway, I have no idea.
@radekdoulik @radical could you please help ?

@pavelsavara
Copy link
Member Author

I compared dotnet.js in both Release and Debug config. There are only cosmetic changes.

@maraf
Copy link
Member

maraf commented Jul 21, 2022

could you please help ?

Here are some instructions how to authenticate
#71393 (comment)

@lewing
Copy link
Member

lewing commented Jul 21, 2022

wait, the npm registry changes mean that anyone trying to build wasm has to generate an azdo PAT and auth npm now?

@pavelsavara
Copy link
Member Author

wait, the npm registry changes mean that anyone trying to build wasm has to generate an azdo PAT and auth npm now?

No, just the one who needs to add new packages to AzDO repo (working as a cache i guess).

@pavelsavara pavelsavara deleted the wasm_bump_dependencies branch July 29, 2022 09:14
@ghost ghost locked as resolved and limited conversation to collaborators Aug 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants