Generic attributes handling in CustomAttributeDecoder #72561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the attribute constructor refers to the generic T in its signature, we would throw `BadImageFormatException`. This adds handling by capturing the generic context and interpreting the signature variables when needed.
|
Tagging subscribers to this area: @dotnet/area-system-reflection-metadata Issue Details@MichalStrehovsky found that System.Reflection.Metadata doesn't handle generic attributes and have fixed in #57466 which needs unit tests added before merge I have cherry picked his commits and added unit test (I could not contribute to the original PR, got permission denied), probably we want it within 7.0 Fixes: #58073
|
buyaa-n
commented
Jul 20, 2022
src/libraries/System.Reflection.Metadata/tests/Metadata/Decoding/CustomAttributeDecoderTests.cs
Show resolved
Hide resolved
This was referenced Aug 3, 2022
src/libraries/System.Reflection.Metadata/tests/Metadata/Decoding/CustomAttributeDecoderTests.cs
Outdated
Show resolved
Hide resolved
…etection.HasAssemblyFiles))]
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@MichalStrehovsky found that System.Reflection.Metadata doesn't handle generic attributes and have fixed in #57466 which needs unit tests added before merge
I have cherry picked his commits and added unit test (I could not contribute to the original PR, got permission denied), probably we want it within 7.0
Fixes: #58073