Skip to content

Fix stackoverflow issue when creating recursive contracts using JsonIgnoreCondition #72186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

eiriktsarpalis
Copy link
Member

Partially reverts #71908 moving serialization capability resolution back to the final configure stage. While these policies are no longer reflected in the user-modifiable JSON contracts, I've added more escape hatches so that any user-provided configuration is respected.

Fix #72175.

@eiriktsarpalis eiriktsarpalis requested a review from krwq July 14, 2022 14:50
@ghost ghost assigned eiriktsarpalis Jul 14, 2022
@eiriktsarpalis eiriktsarpalis added this to the 7.0.0 milestone Jul 14, 2022
@ghost
Copy link

ghost commented Jul 14, 2022

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Partially reverts #71908 moving serialization capability resolution back to the final configure stage. While these policies are no longer reflected in the user-modifiable JSON contracts, I've added more escape hatches so that any user-provided configuration is respected.

Fix #72175.

Author: eiriktsarpalis
Assignees: -
Labels:

area-System.Text.Json

Milestone: -

@eiriktsarpalis eiriktsarpalis merged commit 9d795e6 into dotnet:main Jul 14, 2022
@eiriktsarpalis eiriktsarpalis deleted the fix-recursive-jsonpropertyinfo-stackoverflow branch July 14, 2022 21:17
@ghost ghost locked as resolved and limited conversation to collaborators Aug 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System.Text.Json contract customization: stack overflow when adding recursive properties via JsonMetadataServices
2 participants