-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[release/6.0] [Android] Port getifaddrs implementation from Xamarin.Android #72097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
The |
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsBackport of #71943 to release/6.0 /cc @simonrozsival Customer ImpactIn recent Android versions the data returned by the TestingThere are existing unit tests for the RiskLow. The code is a port of an existing implementation in legacy Xamarin.Android (https://github.com/xamarin/xamarin-android/blob/f149c25c7e5936fad73ddf80b588ca67bbacc24a/src/monodroid/jni/xamarin_getifaddrs.cc). IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
|
Tagging subscribers to 'arch-android': @steveisok, @akoeplinger Issue DetailsBackport of #71943 to release/6.0 /cc @simonrozsival Customer ImpactIn recent Android versions the data returned by the TestingThere are existing unit tests for the RiskLow. The code is a port of an existing implementation in legacy Xamarin.Android (https://github.com/xamarin/xamarin-android/blob/f149c25c7e5936fad73ddf80b588ca67bbacc24a/src/monodroid/jni/xamarin_getifaddrs.cc). IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
|
I'm rerunning one of the CI legs because there was a one CoreCLR failure, but the logs were gone. @marek-safar @steveisok @akoeplinger who can sign-off on this change, and potentially investigate any CI failures if they show up again? Edit: Ah nevermind, this change is for Android, the failure is arm64 windows. We're good. |
carlossanlop
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tactics approved.
Correct milestone applied.
CI failure is unrelated.
No OOB package authoring changes needed (native code only).
Signed off by area owner.
Ready to merge. ![]()
Backport of #71943 to release/6.0
/cc @simonrozsival
Customer Impact
In recent Android versions the data returned by the
getifaddrsfunction is invalid and doesn't allow us to implementSystem.Net.NetworkInformation.GetAllNetworkInterfaces()correctly. The problem was originally reported in the MAUI repo (dotnet/maui#6649, dotnet/android#6973).Testing
There are existing unit tests for the
System.Net.NetworkInformationproject.Risk
Low. The code is a port of an existing implementation in legacy Xamarin.Android (https://github.com/xamarin/xamarin-android/blob/f149c25c7e5936fad73ddf80b588ca67bbacc24a/src/monodroid/jni/xamarin_getifaddrs.cc).
IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.