Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jul 13, 2022

Backport of #71943 to release/6.0

/cc @simonrozsival

Customer Impact

In recent Android versions the data returned by the getifaddrs function is invalid and doesn't allow us to implement System.Net.NetworkInformation.GetAllNetworkInterfaces() correctly. The problem was originally reported in the MAUI repo (dotnet/maui#6649, dotnet/android#6973).

Testing

There are existing unit tests for the System.Net.NetworkInformation project.

Risk

Low. The code is a port of an existing implementation in legacy Xamarin.Android (https://github.com/xamarin/xamarin-android/blob/f149c25c7e5936fad73ddf80b588ca67bbacc24a/src/monodroid/jni/xamarin_getifaddrs.cc).

IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

@github-actions github-actions bot requested a review from marek-safar as a code owner July 13, 2022 14:30
@ghost
Copy link

ghost commented Jul 13, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@simonrozsival
Copy link
Member

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@simonrozsival
Copy link
Member

The runtime-staging lanes contain several failures but all of them are unrelated to the change.

@marek-safar marek-safar added the Servicing-consider Issue for next servicing release review label Jul 18, 2022
@marek-safar marek-safar added this to the 6.0.x milestone Jul 18, 2022
@ghost
Copy link

ghost commented Jul 19, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #71943 to release/6.0

/cc @simonrozsival

Customer Impact

In recent Android versions the data returned by the getifaddrs function is invalid and doesn't allow us to implement System.Net.NetworkInformation.GetAllNetworkInterfaces() correctly. The problem was originally reported in the MAUI repo (dotnet/maui#6649, dotnet/android#6973).

Testing

There are existing unit tests for the System.Net.NetworkInformation project.

Risk

Low. The code is a port of an existing implementation in legacy Xamarin.Android (https://github.com/xamarin/xamarin-android/blob/f149c25c7e5936fad73ddf80b588ca67bbacc24a/src/monodroid/jni/xamarin_getifaddrs.cc).

IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

Servicing-consider, area-System.Net

Milestone: 6.0.x

@ghost
Copy link

ghost commented Jul 19, 2022

Tagging subscribers to 'arch-android': @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #71943 to release/6.0

/cc @simonrozsival

Customer Impact

In recent Android versions the data returned by the getifaddrs function is invalid and doesn't allow us to implement System.Net.NetworkInformation.GetAllNetworkInterfaces() correctly. The problem was originally reported in the MAUI repo (dotnet/maui#6649, dotnet/android#6973).

Testing

There are existing unit tests for the System.Net.NetworkInformation project.

Risk

Low. The code is a port of an existing implementation in legacy Xamarin.Android (https://github.com/xamarin/xamarin-android/blob/f149c25c7e5936fad73ddf80b588ca67bbacc24a/src/monodroid/jni/xamarin_getifaddrs.cc).

IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

Servicing-consider, area-System.Net, os-android

Milestone: 6.0.x

@rbhanda rbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jul 19, 2022
@rbhanda rbhanda modified the milestones: 6.0.x, 6.0.9 Jul 19, 2022
@carlossanlop
Copy link
Contributor

carlossanlop commented Aug 11, 2022

I'm rerunning one of the CI legs because there was a one CoreCLR failure, but the logs were gone.

@marek-safar @steveisok @akoeplinger who can sign-off on this change, and potentially investigate any CI failures if they show up again?

Edit: Ah nevermind, this change is for Android, the failure is arm64 windows. We're good.

Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tactics approved.
Correct milestone applied.
CI failure is unrelated.
No OOB package authoring changes needed (native code only).
Signed off by area owner.
Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit 1c9d3df into release/6.0 Aug 11, 2022
@carlossanlop carlossanlop deleted the backport/pr-71943-to-release/6.0 branch August 11, 2022 19:48
@ghost ghost locked as resolved and limited conversation to collaborators Sep 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants