Add TAR tests that verify ExtractToFile works with special files#71988
Merged
carlossanlop merged 1 commit intodotnet:mainfrom Jul 12, 2022
carlossanlop:TarTestsSpecialFilesExtractToFile
Merged
Add TAR tests that verify ExtractToFile works with special files#71988carlossanlop merged 1 commit intodotnet:mainfrom carlossanlop:TarTestsSpecialFilesExtractToFile
carlossanlop merged 1 commit intodotnet:mainfrom
carlossanlop:TarTestsSpecialFilesExtractToFile
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsWe already have tests that verify:
But we don't yet have tests for successful extraction of such entries entry types to the file system. Pending confirm that the exotic runtime-extra-platforms do not have weird behaviors.
|
Contributor
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
adamsitnik
approved these changes
Jul 12, 2022
Member
adamsitnik
left a comment
There was a problem hiding this comment.
LGTM, thank you @carlossanlop !
Contributor
Author
|
The test failures in runtime-extra-platforms are unrelated to Tar. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already have tests that verify:
TarEntryinstances for fifo, block & character device entry types.DeviceMajorandDeviceMinor.TarEntryinstances, verifying the correct values ofDeviceMajorandDeviceMinor.But we don't yet have tests for successful extraction of such entries entry types to the file system.
Pending confirm that the exotic runtime-extra-platforms do not have weird behaviors.