-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Tar: for directories, use a default mask that has the 'x' bit. #71760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Without the 'x'-bit, the directories that get created are not accessible.
|
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsWithout the 'x'-bit, the directories that get created are not accessible. @eerhardt @carlossanlop @dotnet/area-system-io ptal.
|
src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHelpers.cs
Outdated
Show resolved
Hide resolved
Do we need a test that untars something containing a directory and then tries to access it, e.g. copying something inside it, reading something from it, etc.? It sounds like that would fail without this fix? |
Co-authored-by: Stephen Toub <stoub@microsoft.com>
Yes, it would fail without the fix. |
Co-authored-by: Stephen Toub <stoub@microsoft.com>
eerhardt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
carlossanlop
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I ran the runtime-extra-platforms pipeline, to make sure all the exotic platforms pass too.
If it all looks good, we can merge it.
|
No tar failures. |
Without the 'x'-bit, the directories that get created are not accessible.
@eerhardt @carlossanlop @dotnet/area-system-io ptal.