Skip to content

Re-enable test now that the msbuild fix has propagated #71745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2022
Merged

Re-enable test now that the msbuild fix has propagated #71745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60cf3d0
Re-enable test now that the msbuild fix has propagated
davidwrighton Jul 7, 2022
f6f4c53
Fix the data for the test as well as the test code
davidwrighton Jul 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/tests/reflection/GenericAttribute/GenericAttributeMetadata.il
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,13 @@

// --- The following custom attribute is added automatically, do not uncomment -------
// .custom instance void [mscorlib]System.Diagnostics.DebuggableAttribute::.ctor(valuetype [mscorlib]System.Diagnostics.DebuggableAttribute/DebuggingModes) = ( 01 00 07 01 00 00 00 00 )
/* Re-enable once the fix to https://github.com/dotnet/msbuild/issues/6734 propagates to this repo.
.custom instance void class SingleAttribute`1<int32>::.ctor() = ( 01 00 00 00 )
.custom instance void class SingleAttribute`1<bool>::.ctor() = ( 01 00 00 00 )
.custom instance void class MultiAttribute`1<int32>::.ctor() = ( 01 00 00 00 )
.custom instance void class MultiAttribute`1<int32>::.ctor(!0) = ( 01 00 01 00 00 00 00 00 )
.custom instance void class MultiAttribute`1<int32>::.ctor() = ( 01 00 01 00 54 08 05 56 61 6C 75 65 02 00 00 00 ) // ....T..Value....
.custom instance void class MultiAttribute`1<bool>::.ctor() = ( 01 00 00 00 )
.custom instance void class MultiAttribute`1<bool>::.ctor(!0) = ( 01 00 01 00 00 ) */
.custom instance void class MultiAttribute`1<bool>::.ctor(!0) = ( 01 00 01 00 00 )
.hash algorithm 0x00008004
.ver 0:0:0:0
}
Expand Down
2 changes: 0 additions & 2 deletions src/tests/reflection/GenericAttribute/GenericAttributeTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ class Program
{
static int Main(string[] args)
{
/* Re-enable once the fix to https://github.com/dotnet/msbuild/issues/6734 propagates to this repo.
Assembly assembly = typeof(Class).GetTypeInfo().Assembly;
Assert(CustomAttributeExtensions.GetCustomAttribute<SingleAttribute<int>>(assembly) != null);
Assert(((ICustomAttributeProvider)assembly).GetCustomAttributes(typeof(SingleAttribute<int>), true) != null);
Expand All @@ -20,7 +19,6 @@ static int Main(string[] args)
Assert(((ICustomAttributeProvider)assembly).IsDefined(typeof(SingleAttribute<bool>), true));
Assert(CustomAttributeExtensions.GetCustomAttributes(assembly, typeof(SingleAttribute<>)).GetEnumerator().MoveNext());
Assert(CustomAttributeExtensions.GetCustomAttributes(assembly, typeof(SingleAttribute<>)).GetEnumerator().MoveNext());
*/

// Uncomment when https://github.com/dotnet/runtime/issues/66168 is resolved
// Module module = programTypeInfo.Module;
Expand Down