Skip to content

Consolidate Newtonsoft versions #71402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 11, 2022
Merged

Consolidate Newtonsoft versions #71402

merged 4 commits into from
Jul 11, 2022

Conversation

am11
Copy link
Member

@am11 am11 commented Jun 28, 2022 

Newtonsoft.Json => v13.0.1
Newtonsoft.Json.Bson => v1.0.2

@am11 am11 requested a review from marek-safar as a code owner June 28, 2022 20:40
@ghost
Copy link

ghost commented Jun 28, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jun 28, 2022
jkoritzinsky
jkoritzinsky reviewed Jun 28, 2022
View reviewed changes
Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't move the projects under the installer test assets to use the versions in eng/Versions.props as they are copied over to Helix and built independently of the rest of the repo.

@ghost
Copy link

ghost commented Jun 28, 2022

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details 
Newtonsoft.Json => v13.0.1
Newtonsoft.Json.Bson => v1.0.2
Author: am11
Assignees: -
Labels:

area-Infrastructure, community-contribution
Milestone: -

@am11
Copy link
Member Author

am11 commented Jun 28, 2022

@jkoritzinsky, I know. That's why I have added an additional property for those projects.

@jkoritzinsky
Copy link
Member

I totally missed that in the diff. This looks good to me then! I'd like to get some feedback from the owners of the host tests before approving. @vitek-karas @agocke

@am11
Set JsonTextReader's MaxDepth to null
21005c8 
In v13, defaults are changed from null to 64.
@am11 am11 force-pushed the feature/external/newtonsoft-versions branch from 2efecd6 to 21005c8 Compare June 28, 2022 22:55
vitek-karas
vitek-karas approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@vitek-karas vitek-karas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The host/hostests changes look good. Thanks a lot!

@am11 am11 requested review from thaystg and radical as code owners July 11, 2022 04:47
@am11
Copy link
Member Author

am11 commented Jul 11, 2022

@jkoritzinsky, this one is ready. Other repos have also aligned to this version of Newtonsoft (e.g. dotnet/sdk#26173).

@jkoritzinsky jkoritzinsky merged commit 35d3f2b into dotnet:main Jul 11, 2022
@jakobbotsch jakobbotsch mentioned this pull request Jul 11, 2022
Closed
@am11 am11 mentioned this pull request Jul 11, 2022
Merged
@am11 am11 deleted the feature/external/newtonsoft-versions branch July 24, 2022 07:28
@ghost ghost locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky left review comments

@vitek-karas vitek-karas vitek-karas approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar

@thaystg thaystg Awaiting requested review from thaystg

@radical radical Awaiting requested review from radical

Assignees
No one assigned
Labels
area-Infrastructure community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@am11 @jkoritzinsky @vitek-karas