Skip to content

WIP: Add private {ReadOnly}Span ctor that takes a ref, index and length #70240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Jun 4, 2022

No description provided.

@ghost ghost added area-System.Memory community-contribution Indicates that the PR has been added by a community member labels Jun 4, 2022
@ghost
Copy link

ghost commented Jun 4, 2022

Tagging subscribers to this area: @dotnet/area-system-memory
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: xtqqczze
Assignees: -
Labels:

area-System.Memory

Milestone: -

@jkotas
Copy link
Member

jkotas commented Jun 4, 2022

What are you trying to achieve with this?

@xtqqczze
Copy link
Contributor Author

xtqqczze commented Jun 5, 2022

What are you trying to achieve with this?

Just a code cleanup. I was hoping to see no regressions on asmdiffs.

@jkotas
Copy link
Member

jkotas commented Jun 6, 2022

The new method in Span<T> will make every Span<T> instantiation more expensive. So this is a footprint regression at minimum.

@jkotas
Copy link
Member

jkotas commented Jun 6, 2022

Thank you for contribution. We do not want to make Span<T> instantiations more expensive for this minor style improvement.

@jkotas jkotas closed this Jun 6, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Memory community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants