Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve DisplayNameHelpers for NativeAOT #70084

Merged
merged 4 commits into from
Jun 2, 2022

Commits on Jun 1, 2022

  1. Improve DisplayNameHelpers for NativeAOT

    These helpers are used to report names of things in warnings. The functional changes are:
    * For method parameters, use the parameter name if available (and only if not fallback to the #1 notation)
    * For property accessor methods, use the C# naming scheme, so for example Type.Property.get instead of Type.get_Property.
    
    Both of these changes are in preparation to bring NativeAOT closer in behavior to ILLink and the trim analyzers.
    
    For this I moved some of the helpers to the common shared code.
    
    Some unrelated code cleanup as well.
    vitek-karas committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    afae890 View commit details
    Browse the repository at this point in the history
  2. PR feedback

    vitek-karas committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    f7e31d0 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2022

  1. Apply suggestions from code review

    Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
    vitek-karas and MichalStrehovsky authored Jun 2, 2022
    Configuration menu
    Copy the full SHA
    9bf363c View commit details
    Browse the repository at this point in the history
  2. Feedback

    vitek-karas committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    a4156e9 View commit details
    Browse the repository at this point in the history