Fix packs.product subset build with gcc #68998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsAfter 7ff3ac6 was merged, the gcc build was failing. I have narrowed it down to $ ./build.sh packs.product -gcc
....
crossgen2 -> /runtime/artifacts/bin/coreclr/Linux.x64.Debug/crossgen2/linux-x64/crossgen2.dll
/runtime/artifacts/bin/coreclr/Linux.x64.Debug/build/Microsoft.NETCore.Native.Unix.props(110,5): error : Platform linker ('clang') not found. Try installing clang or the appropriate package for your platform to resolve the problem. [/runtime/src/coreclr/tools/aot/crossgen2/crossgen2.csproj]
...This fix sets The leading hyphen, if present, is proactively trimmed off from the value for both properties (currently it eventually gets dropped here and line 39).
|
jkotas
approved these changes
May 7, 2022
ViktorHofer
approved these changes
May 9, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After 7ff3ac6 was merged, the gcc build was failing. I have narrowed it down to
packs.productsubset:This fix sets
CppCompilerAndLinkerproperty ineng/build.sh(where we set another propertyCompilerfor similar purpose).The leading hyphen, if present, is proactively trimmed off from the value for both properties (currently it eventually gets dropped here and line 39).