Skip to content

Delete stale IgnoreCaseRelation regex tests #68857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2022

Conversation

stephentoub
Copy link
Member

These are from when NonBacktracking maintained its own hardcoded set of IgnoreCase-related tables. Those no longer exist, making these tests defunct.

Closes #60753

These are from when NonBacktracking maintained its own hardcoded set of IgnoreCase-related tables.  Those no longer exist, making these tests defunct.
@stephentoub stephentoub added this to the 7.0.0 milestone May 4, 2022
@stephentoub stephentoub requested a review from joperezr May 4, 2022 14:48
@ghost ghost assigned stephentoub May 4, 2022
@ghost
Copy link

ghost commented May 4, 2022

Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions
See info in area-owners.md if you want to be subscribed.

Issue Details

These are from when NonBacktracking maintained its own hardcoded set of IgnoreCase-related tables. Those no longer exist, making these tests defunct.

Closes #60753

Author: stephentoub
Assignees: stephentoub
Labels:

area-System.Text.RegularExpressions

Milestone: 7.0.0

Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed those in my original PR. Thanks for cleaning up.

@stephentoub stephentoub merged commit 3929af4 into dotnet:main May 5, 2022
@stephentoub stephentoub deleted the deletetests branch May 5, 2022 00:09
@ghost ghost locked as resolved and limited conversation to collaborators Jun 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure System.Text.RegularExpressions.Tests.RegexCultureTests.TestIgnoreCaseRelationBorderCasesInNonBacktracking(options: NonBacktracking)
2 participants