DRAFT - Multi throw if nulls #68234
DRAFT - Multi throw if nulls #68234
Conversation
ghost
added
the
community-contribution
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
ghost
added
new-api-needs-documentation
and removed
community-contribution
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
| { | ||
| public void Bar(string s1, string s2) | ||
| { | ||
| ArgumentNullException.ThrowIfNull(s1, (object?)s2); // sadly, have to cast to force the correct overload. |
There was a problem hiding this comment.
Unfortunately, we have to cast to force the correct overload. This also impacts the parameter name reported in the exception message.
|
Hello @SteveDunn and thanks for taking the initiative. Your PR is adding a new public API which first must be formally suggested and approved according to the process. Until that happens, I'm afraid I have to close it. Feel free to open another one if the API gets approved. |
|
@teo-tsirpanis - understood. My idea didn't work anyway, because of overload resolution. I should've closed it myself, but didn't think of that (I just thought to make if |
ghost
locked as resolved and limited conversation to collaborators
There's some issues with this idea WRT method overload resolution. Just creating this PR to show the issue