Skip to content

JIT: fix assert seen in some OSR cases #68048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2022
Merged

JIT: fix assert seen in some OSR cases #68048

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fe7396
JIT: fix assert seen in some OSR cases
AndyAyersMS Apr 14, 2022
acd6d0d
better fix
AndyAyersMS Apr 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/coreclr/jit/gschecks.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,16 +53,26 @@ void Compiler::gsCopyShadowParams()
}

// Allocate array for shadow param info
//
gsShadowVarInfo = new (this, CMK_Unknown) ShadowParamVarInfo[lvaCount]();

// Find groups of variables assigned to each other, and also
// tracks variables which are dereferenced and marks them as ptrs.
// Look for assignments to *p, and ptrs passed to functions
//
if (gsFindVulnerableParams())
{
// Replace vulnerable params by shadow copies.
//
gsParamsToShadows();
}
else
{
// There are no vulnerable params.
// Clear out the info to avoid looking at stale data.
//
gsShadowVarInfo = nullptr;
}
}

// This struct tracks how a tree is being used
Expand Down