Skip to content

Conversation

@jakobbotsch
Copy link
Member

@jakobbotsch jakobbotsch commented Mar 13, 2022

- Enable tests relying on implicit tailcalls
- Enable all ABI stress tests
@ghost ghost assigned jakobbotsch Mar 13, 2022
@ghost
Copy link

ghost commented Mar 13, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Mar 13, 2022

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details
Author: jakobbotsch
Assignees: jakobbotsch
Labels:

area-Infrastructure-coreclr

Milestone: -

@jakobbotsch
Copy link
Member Author

#13241 does not repro within the first 1000 tests anymore (presumably after seeding changes in #50767 and #63409). However I will still disable the tests I believe can be affected since they can still hit the problem if we run with a non-standard seed.

@jakobbotsch jakobbotsch added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI and removed area-Infrastructure-coreclr labels Mar 14, 2022
@ghost
Copy link

ghost commented Mar 14, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details
Author: jakobbotsch
Assignees: jakobbotsch
Labels:

area-CodeGen-coreclr

Milestone: -

@jakobbotsch
Copy link
Member Author

cc @dotnet/jit-contrib, simple enabling of some tailcall ARM32 tests

@jakobbotsch
Copy link
Member Author

Enabled all ABI stress tests since #13241 was fixed.

@jakobbotsch jakobbotsch merged commit 688d2d0 into dotnet:main Mar 16, 2022
@jakobbotsch jakobbotsch deleted the enable-arm32-tests branch March 16, 2022 09:51
radekdoulik pushed a commit to radekdoulik/runtime that referenced this pull request Mar 30, 2022
- Enable tests relying on implicit tailcalls
- Enable all ABI stress tests
@ghost ghost locked as resolved and limited conversation to collaborators Apr 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants