JIT: fix scalability issue in redundant branch optimizer #66259
Conversation
In methods with long skinny dominator trees and lots of redundant branches the jit can spend too much time trying to optimize the branches. Place a limit on the number of redundant branches with matching VNs that the jit will consider for a given branch. Fixes dotnet#66067.
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsIn methods with long skinny dominator trees and lots of redundant branches Place a limit on the number of redundant branches with matching VNs that Fixes #66067.
|
|
Local SPMI run sees fairly minimal diffs (15 methods, maybe 4 different "non-test" methods). @jakobbotsch PTAL We should consider porting this one to .NET 6. |
|
Runtimes for the example from the issue:
|
|
/backport to release/6.0 |
|
Looks like the backport bot is locked out. |
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/2283305828 |
ghost
locked as resolved and limited conversation to collaborators
In methods with long skinny dominator trees and lots of redundant branches
the jit can spend too much time trying to optimize the branches.
Place a limit on the number of redundant branches with matching VNs that
the jit will consider for a given branch.
Fixes #66076.