Skip to content

[wasm] Replace active issue for browser platform with NodeJS only #65505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2022

Conversation

maraf
Copy link
Member

@maraf maraf commented Feb 17, 2022

In #63441 I have disabled some tests for whole browser platform.
Those tests don't work only on node, on browser they work.

This PR replaces disabling tests for browser platform with node only.

@maraf maraf added arch-wasm WebAssembly architecture area-Infrastructure-mono labels Feb 17, 2022
@maraf maraf added this to the 7.0.0 milestone Feb 17, 2022
@maraf maraf requested a review from pavelsavara February 17, 2022 13:34
@maraf maraf self-assigned this Feb 17, 2022
@ghost
Copy link

ghost commented Feb 17, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

In #63441 I have disabled some tests for whole browser platform.
Those tests don't work only on node, on browser they work.

This PR replaces disabling tests for browser platform with node only.

Author: maraf
Assignees: maraf
Labels:

arch-wasm, area-Infrastructure-mono

Milestone: 7.0.0

@maraf
Copy link
Member Author

maraf commented Feb 17, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@maraf maraf merged commit d59bfff into dotnet:main Feb 18, 2022
@maraf maraf deleted the WasmWebSocketTestsDisableOnlyNodeJs branch February 18, 2022 07:55
@ghost ghost locked as resolved and limited conversation to collaborators Mar 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants