[Group 3] Enable nullable annotations for Microsoft.Extensions.Logging

[maxkoshevoi]

Related to #43605

Questions:

• Seems like it should be GetRequiredService here, since DisposingLoggerFactory doesn't accept null loggerFactory
  

  runtime/src/libraries/Microsoft.Extensions.Logging/src/LoggerFactory.cs

  Lines 97 to 98 in 348e06c

  	ILoggerFactory loggerFactory = serviceProvider.GetService<ILoggerFactory>();
  	return new DisposingLoggerFactory(loggerFactory, serviceProvider);

• Logger can be null here, I see no checks that say it couldn't

  runtime/src/libraries/Microsoft.Extensions.Logging/src/LoggerInformation.cs

  Line 63 in 348e06c

  return Logger.BeginScope<TState>(state);

  runtime/src/libraries/Microsoft.Extensions.Logging/src/LoggerFactory.cs

  Line 236 in 348e06c

  scopeLoggers?.Add(new ScopeLogger(logger: null, externalScopeProvider: _scopeProvider));

• Not sure if Alias can be null. Marked it as non-nullable for now: https://github.com/dotnet/runtime/blob/main/src/libraries/Microsoft.Extensions.Logging/src/ProviderAliasAttribute.cs

[ghost]

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

[ghost]

Tagging subscribers to this area: @dotnet/area-extensions-logging
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Related to #43605

Questions:

• Seems like it should be GetRequiredService here, since DisposingLoggerFactory doesn't accept null loggerFactory
  

  runtime/src/libraries/Microsoft.Extensions.Logging/src/LoggerFactory.cs

  Lines 97 to 98 in 348e06c

  	ILoggerFactory loggerFactory = serviceProvider.GetService<ILoggerFactory>();
  	return new DisposingLoggerFactory(loggerFactory, serviceProvider);

• Logger can be null here, I see no checks that say it couldn't

  runtime/src/libraries/Microsoft.Extensions.Logging/src/LoggerInformation.cs

  Line 63 in 348e06c

  return Logger.BeginScope<TState>(state);

  runtime/src/libraries/Microsoft.Extensions.Logging/src/LoggerFactory.cs

  Line 236 in 348e06c

  scopeLoggers?.Add(new ScopeLogger(logger: null, externalScopeProvider: _scopeProvider));

• Not sure if Alias can be null. Marked it as non-nullable for now: https://github.com/dotnet/runtime/blob/main/src/libraries/Microsoft.Extensions.Logging/src/ProviderAliasAttribute.cs

Author:	maxkoshevoi
Assignees:	-
Labels:	new-api-needs-documentation, area-Extensions-Logging, community-contribution
Milestone:	-

[maxkoshevoi]

Have no idea, why CI fails. ref signatures looks the same as src, and dotnet msbuild /t:GenerateReferenceAssemblySource doesn't change anything.

[maryamariyan]

Have no idea, why CI fails. ref signatures looks the same as src, and dotnet msbuild /t:GenerateReferenceAssemblySource doesn't change anything.

looking

[maryamariyan]

I noticed that running

> dotnet build src\libraries\Microsoft.Extensions.Logging\src\ /t:GenerateReferenceAssemblySource -c Release

auto generates the small diff in 23dc4b5 .

Would you like to push this commit onto this PR to see if retriggering CI this way would fix the CI failures?

[maryamariyan]

Aside the question in https://github.com/dotnet/runtime/pull/65262/files#r817973746 the rest looks fine to me.

[maxkoshevoi]

@maryamariyan Hi, I'm in Ukraine (currently relatively safe in Lviv), so cannot be as active. I'll try to address the comments when I can, but if I don't respond for tool long or disappear altogether, feel free to commit to my branches.

[joperezr]

You need to invoke Pack in order for package validation to run, and for it to emit the baseline file. Try doing: \src\libraries\Microsoft.Extensions.Logging\src> dotnet build /p:GenerateCompatibilitySuppressionFile=true /p:BuildAllConfigurations=true (passing in the BuildAllConfigurations=true option triggers GeneratePackageOnBuild to be set to true which builds the package)

[maryamariyan]

LGTM aside from the ScopeLogger portion in #65262 (comment)

[eerhardt]

This looks great. Thanks again for all the work here, @maxkoshevoi!

[SteveDunn]

@maryamariyan Hi, I'm in Ukraine (currently relatively safe in Lviv), so cannot be as active. I'll try to address the comments when I can, but if I don't respond for tool long or disappear altogether, feel free to commit to my branches.

Stay safe my friend.