[release/6.0] Port ICU tests fix for server core x86 #65038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
|
Tagging subscribers to this area: @dotnet/area-system-globalization Issue Detailsicu is not present on Server Core in the SysWOW64. Test only change to help get release branch CI green. Branch is closed at the moment, but this can be merged when it is opened.
|
danmoseley
approved these changes
Feb 9, 2022
Member
danmoseley
left a comment
danmoseley
left a comment
There was a problem hiding this comment.
thanks for keeping the tests healthy in servicing branches..
tarekgh
approved these changes
Feb 9, 2022
Member
Author
Trying my best, with so many changes it's been a challenge but I think we are getting there. |
akoeplinger
reviewed
Feb 10, 2022
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
akoeplinger
approved these changes
Feb 14, 2022
Member
Author
|
Thanks, @akoeplinger for pushing the missing platform detection member. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
icu is not present on Server Core in the SysWOW64.
Test only change to help get release branch CI green.
Branch is closed at the moment, but this can be merged when it is opened.