Skip to content

Add a new wrapper runtime-wasm.yml to be used from azdo #65032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 9, 2022
Merged

Conversation

radical
Copy link
Member

@radical radical commented Feb 8, 2022

Currently, we have runtime-wasm in azdo pointing to
runtime-extra-platforms.yml, which has some scheduled triggers
defined. azdo seems to use these for running runtime-wasm too.

Instead, in azdo use a new runtime-wasm.yml for runtime-wasm pipeline, so
we can explicitly avoid the scheduled triggers. This yml just uses the
existing runtime-extra-platforms-wasm.yml.

Currently, we have `runtime-wasm` in azdo pointing to
`runtime-extra-platforms.yml`, which has some scheduled triggers
defined. azdo seems to use these for running `runtime-wasm` too.

Instead, in azdo use a new `runtime-wasm.yml` for `runtime-wasm` pipeline, so
we can explicitly avoid the scheduled triggers. This yml just uses the
existing `runtime-extra-platforms-wasm.yml`.
@ghost
Copy link

ghost commented Feb 8, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost assigned radical Feb 8, 2022
@radical
Copy link
Member Author

radical commented Feb 8, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost
Copy link

ghost commented Feb 8, 2022

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Currently, we have runtime-wasm in azdo pointing to
runtime-extra-platforms.yml, which has some scheduled triggers
defined. azdo seems to use these for running runtime-wasm too.

Instead, in azdo use a new runtime-wasm.yml for runtime-wasm pipeline, so
we can explicitly avoid the scheduled triggers. This yml just uses the
existing runtime-extra-platforms-wasm.yml.

Author: radical
Assignees: radical
Labels:

area-Infrastructure

Milestone: -

Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radical
Copy link
Member Author

radical commented Feb 8, 2022

@safern do we need to wait for the builds to complete before merging this one?

@safern
Copy link
Member

safern commented Feb 9, 2022

It seems like runtime-wasm skipped all legs: https://dev.azure.com/dnceng/public/_build/results?buildId=1601074&view=results it seems like the evaluate paths step wasn't inserted for some reason.

@safern
Copy link
Member

safern commented Feb 9, 2022

Ah, you need to import the variables template 😄

@radical
Copy link
Member Author

radical commented Feb 9, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Feb 9, 2022

Failures are unrelated.

@radical radical merged commit f51fe4b into main Feb 9, 2022
@radical radical deleted the wasm-ci-only branch February 9, 2022 05:23
@ghost ghost locked as resolved and limited conversation to collaborators Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants