-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Use global caching in JsonSerializerOptions #64646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
eiriktsarpalis
merged 10 commits into
dotnet:main
from
eiriktsarpalis:member-accessor-caching
Feb 14, 2022
Merged
Use global caching in JsonSerializerOptions #64646
eiriktsarpalis
merged 10 commits into
dotnet:main
from
eiriktsarpalis:member-accessor-caching
Feb 14, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-text-json Issue DetailsWork in progress.
Contributes to #40072.
|
eiriktsarpalis
commented
Feb 1, 2022
...son/src/System/Text/Json/Serialization/Metadata/ReflectionEmitCachingMemberAccessor.Cache.cs
Outdated
Show resolved
Hide resolved
61114a0 to
4456cf1
Compare
4456cf1 to
8050aad
Compare
eiriktsarpalis
commented
Feb 4, 2022
...Text.Json/src/System/Text/Json/Serialization/Metadata/ReflectionEmitCachingMemberAccessor.cs
Outdated
Show resolved
Hide resolved
8050aad to
295796f
Compare
eiriktsarpalis
commented
Feb 4, 2022
...son/src/System/Text/Json/Serialization/Metadata/ReflectionEmitCachingMemberAccessor.Cache.cs
Outdated
Show resolved
Hide resolved
layomia
reviewed
Feb 9, 2022
...Text.Json/src/System/Text/Json/Serialization/Metadata/ReflectionEmitCachingMemberAccessor.cs
Outdated
Show resolved
Hide resolved
...son/src/System/Text/Json/Serialization/Metadata/ReflectionEmitCachingMemberAccessor.Cache.cs
Outdated
Show resolved
Hide resolved
...ries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.Converters.cs
Outdated
Show resolved
Hide resolved
...System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/JsonSerializerContextTests.cs
Outdated
Show resolved
Hide resolved
...son/src/System/Text/Json/Serialization/Metadata/ReflectionEmitCachingMemberAccessor.Cache.cs
Outdated
Show resolved
Hide resolved
...braries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.Caching.cs
Outdated
Show resolved
Hide resolved
...braries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.Caching.cs
Outdated
Show resolved
Hide resolved
…ion/Metadata/ReflectionEmitCachingMemberAccessor.Cache.cs
d0ad2ef to
0e049e7
Compare
layomia
approved these changes
Feb 11, 2022
eiriktsarpalis
commented
Feb 11, 2022
...braries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.Caching.cs
Outdated
Show resolved
Hide resolved
…ion/JsonSerializerOptions.Caching.cs
vitek-karas
reviewed
Feb 14, 2022
...braries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.Caching.cs
Show resolved
Hide resolved
stephentoub
reviewed
Feb 15, 2022
...braries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.Caching.cs
Outdated
Show resolved
Hide resolved
...braries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.Caching.cs
Outdated
Show resolved
Hide resolved
...braries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.Caching.cs
Show resolved
Hide resolved
...braries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.Caching.cs
Show resolved
Hide resolved
...braries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.Caching.cs
Show resolved
Hide resolved
...braries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.Caching.cs
Show resolved
Hide resolved
...braries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.Caching.cs
Show resolved
Hide resolved
eiriktsarpalis
added a commit
to eiriktsarpalis/runtime
that referenced
this pull request
Feb 15, 2022
This was referenced Feb 15, 2022
eiriktsarpalis
added a commit
that referenced
this pull request
Feb 15, 2022
Contributor
This was referenced Feb 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies global caching for reflection metadata in two separate layers:
MethodAccessorlayer caching generated dynamic methods.JsonSerializerOptionscaching, using shared caching contexts shared across multipleJsonSerializerOptionsinstances "up to equivalence".Contributes to #40072.
Performance
Using benchmarks from dotnet/performance#2236