Explicit test for injecting scoped IServiceProvider (#63225) #64558
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #63226 which only adds a new test without modifying the existing ones.
The new test is analogous to the existing
SingletonServiceCanBeResolvedFromScope
but covers the more general (at least from my point of view) case of non-singleton injection.I have also updated
LightInjectDependencyInjectionSpecificationTests
to skip this new test since it otherwise fails on the last line of the testAssert.NotSame(fakeServiceFromScope1, fakeServiceFromScope2)
, meaning that LightInject actually injects the same scoped or transient service instance in both of the created service provider scopes - probably the result of making the originalSingletonServiceCanBeResolvedFromScope
test pass.