Use Reference items instead of P2Ps for inbox libs #64508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsSome libraries still had ProjectReferences to libraries which refs
|
Some libraries still had ProjectReferences to libraries which refs were added to the targeting pack with the last release. Therefore these references can just be normal "Reference" items instead of P2Ps.
ViktorHofer
force-pushed
the
UseReferencesInsteadOfP2Ps
branch
from
f08df56 to
6e03bdf
Compare
ericstj
approved these changes
Jan 31, 2022
Such validation (either via a target or even without one) could be easily implemented. Ideally we would go the opposite way and use P2Ps everywhere which is why I'm a bit torn. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some libraries still had ProjectReferences to libraries which refs
were added to the targeting pack with the last release. Therefore these
references can just be normal "Reference" items instead of P2Ps.