[release/6.0] [mono] Fix downcast check in Array.CopySlow #64479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
where each element in the source array is the appropriate type
When we have to resort to checking element by element, compare the type of each actual element with the destination type. In particular, not the destinations underlying type when it's an enum - we don't want to allow unrelated enums using the same representation to copy over. Fixes #64387
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
lambdageek
added
Servicing-consider
lewing
added
Servicing-approved
lewing
approved these changes
Feb 1, 2022
Member
|
coreclr failure is unrelated |
Member
|
Failure is: #64389 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #64469 to release/6.0
/cc @lambdageek
Customer Impact
Valid customer code that copies
object[]to a more specific array type with Enum elements may throw unexpected InvalidCastExceptions on WebAssembly, iOS and Android despite working in desktop configurations.Testing
Manual testing and CI regression testing.
Risk
Moderate: The fix removes a one type check and relaxes another before performing an unsafe copy operation. Existing code is unlikely to become broken. New code may incorrectly allow an unexpected copy of some valuetypes leading to silent data corruption instead of a runtime exception.