Skip to content

Re-enable arm32 windows testing #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2019
Merged

Re-enable arm32 windows testing #642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions eng/pipelines/common/platform-matrix.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,7 @@ jobs:
helixQueuesTemplate: ${{ parameters.helixQueuesTemplate }}
osGroup: Windows_NT
archType: arm
platform: Windows_NT_arm
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This led us down the path of not actually adding a windows_nt_arm queue. Which is why our ci currently skips windows arm32

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Maybe we should error out if Queues are empty? Rather than just skipping that step?

That's what happens for Libraries and it catches errors like that.

jobParameters:
stagedBuild: ${{ parameters.stagedBuild }}
buildConfig: ${{ parameters.buildConfig }}
Expand Down
7 changes: 2 additions & 5 deletions eng/pipelines/coreclr/templates/helix-queues-setup.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,15 +115,12 @@ jobs:

# Windows_NT arm
- ${{ if eq(parameters.platform, 'Windows_NT_arm') }}:
# NOTE: there are no queues specified for Windows_NT_arm public with helixQueueGroup='pr'. This means that specifying
# Windows_NT_arm for a PR job causes a build, but no test run. If the test build and test runs were separate jobs,
# this could be more explicit (and less subtle).
- ${{ if and(eq(variables['System.TeamProject'], 'public'), in(parameters.jobParameters.helixQueueGroup, 'ci', 'corefx')) }}:
- ${{ if and(eq(variables['System.TeamProject'], 'public'), in(parameters.jobParameters.helixQueueGroup, 'pr', 'ci', 'corefx')) }}:
- Windows.10.Arm64.Open
- ${{ if eq(variables['System.TeamProject'], 'internal') }}:
- Windows.10.Arm64

# Windows_NT arm
# Windows_NT arm64
- ${{ if eq(parameters.platform, 'Windows_NT_arm64') }}:
# TODO: Consider adding Windows.10.Arm64.Open here if capacity is enough for handling both Windows_NT/arm and Windows_NT/arm64 testing
- ${{ if eq(variables['System.TeamProject'], 'internal') }}:
Expand Down