Drop the Debug Windows x64 NativeAOT leg since we have a Checked leg. #64150
Conversation
|
Tagging subscribers to this area: @dotnet/area-meta Issue DetailsSince the Debug and Checked builds each contain asserts and other diagnostic assets, the runs for both Debug and Checked on Windows x64 for NativeAOT seems excessive. The last build times I noted are below. Seems like we would have enough coverage with just a Checked build. Debug: ~90 minutes
|
|
Checked has optimizations enabled in the codegen so we will be losing coverage of unoptimized codegen with this. I already tried to minimize the number of legs we run and this is the minimum I came up with. If we really need to drop one, it should be Linux. Windows tests more and that's why it takes more time than the Linux leg. Either way we will be losing coverage of unoptimized codegen. Linux and Windows are different enough that it warranted the leg. You can see we already don't test on alpine and mac because they're close enough to Linux that it doesn't matter. |
|
@MichalStrehovsky Okay. Thanks for the details. Sounds like having both was intentional. I'll close this PR. |
|
Speeding these legs up is one of the things in looking into in the background. E.g. this one just merged that helps a bit: #64035. I would also like to stop building oob libraries like the Microsoft.Extensions stuff and there's other stuff we can do that would benefit this and other legs. |
ghost
locked as resolved and limited conversation to collaborators
Since the Debug and Checked builds each contain asserts and other diagnostic assets, the runs for both Debug and Checked on Windows x64 for NativeAOT seems excessive. The last build times I noted are below. Seems like we would have enough coverage with just a Checked build.
Debug: ~90 minutes
Checked: ~60 minutes
/cc @MichalStrehovsky @agocke