Add AvxVnni support for NativeAOT #63563
Conversation
* Program.cs: if AVX instruction set was selected as a minimum requirement, allow AvxVnni under a runtime check. * HardwareIntrinsicHelpers.Aot.cs: Add support for dynamic `IsSupported` checks for AvxVnni. Also if AvxVnni was selected as a requirement, burn the requirement into the executable so that we can check it at startup. * Startup.cpp: check for AvxVnni so that we can use it in `IsSupported` checks and also fail to start if it's a hard requirement. * Add a test for the NativeAOT-specific parts of the matrix.
ghost
assigned
|
Cc @tannergooding - I missed when AvxVnni was added - this is the extent of NativeAOT changes needed to support new HW intrinsics. Basically, just dealing with the fact that IsSupported can have 3 possible states in NativeAOT - always supported, supported under a runtime check, and always unsupported. |
| Debug.Assert(InstructionSet.X64_AVX == InstructionSet.X86_AVX); | ||
| if (supportedInstructionSet.HasInstructionSet(InstructionSet.X64_AVX)) | ||
| { | ||
| optimisticInstructionSetSupportBuilder.AddSupportedInstructionSet("fma"); | ||
| optimisticInstructionSetSupportBuilder.AddSupportedInstructionSet("bmi"); | ||
| optimisticInstructionSetSupportBuilder.AddSupportedInstructionSet("bmi2"); | ||
| optimisticInstructionSetSupportBuilder.AddSupportedInstructionSet("avxvnni"); |
There was a problem hiding this comment.
This is going to add AVX2 to the list. Is that problematic?
My guess is no since we only use the supportedInstructionSet flags to determine things like Vector<T> length, but seeing as AVX2 is already "missing" here, I thought I'd ask.
There was a problem hiding this comment.
Yeah, AVX2 is probably an omission. I don't think there's a reason why we wouldn't be able to support it under the runtime check.
|
The failure is #63561 (unrelated). |
IsSupportedchecks for AvxVnni. Also if AvxVnni was selected as a requirement, burn the requirement into the executable so that we can check it at startup.IsSupportedchecks and also fail to start if it's a hard requirement.