-
Notifications
You must be signed in to change notification settings - Fork 5k
[Test][Revert] Reverted change to global build job #63483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
/azp run runtime-manual |
Azure Pipelines successfully started running 1 pipeline(s). |
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsMissing paren got added here: #63311, and lanes seem to be failing when it is fixed. So I am reverting the change.
|
Does the change in |
I don't think so. The global-build-job template already takes a runtimeVariant parameter elsewhere, and just sends it to whatever the extraSteps template is, which in this case does nothing with it. |
This breaking 100% of jobs. Can we do a simple full revert of the offending change to unblock with high-confidence? |
Ok, make sense. This PR is now a full revert. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming the jobs pass
Merging to unblock CI |
Missing paren got added here: #63311, and lanes seem to be failing when it is fixed. So I am reverting the change.