Skip to content

[Test][Revert] Reverted change to global build job #63483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 7, 2022

Conversation

naricc
Copy link
Contributor

@naricc naricc commented Jan 7, 2022

Missing paren got added here: #63311, and lanes seem to be failing when it is fixed. So I am reverting the change.

@naricc naricc requested review from radical and DrewScoggins January 7, 2022 00:05
@ghost
Copy link

ghost commented Jan 7, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost assigned naricc Jan 7, 2022
@naricc
Copy link
Contributor Author

naricc commented Jan 7, 2022

/azp run runtime-manual

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost
Copy link

ghost commented Jan 7, 2022

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Missing paren got added here: #63311, and lanes seem to be failing when it is fixed. So I am reverting the change.

Author: naricc
Assignees: naricc
Labels:

area-Infrastructure

Milestone: -

@naricc naricc requested a review from lewing January 7, 2022 00:08
@radical
Copy link
Member

radical commented Jan 7, 2022

Does the change in eng/pipelines/coreclr/perf_slow.yml from that commit, also need to be reverted?

@naricc
Copy link
Contributor Author

naricc commented Jan 7, 2022

Does the change in eng/pipelines/coreclr/perf_slow.yml from that commit, also need to be reverted?

I don't think so. The global-build-job template already takes a runtimeVariant parameter elsewhere, and just sends it to whatever the extraSteps template is, which in this case does nothing with it.

@jkotas
Copy link
Member

jkotas commented Jan 7, 2022

This breaking 100% of jobs. Can we do a simple full revert of the offending change to unblock with high-confidence?

@naricc
Copy link
Contributor Author

naricc commented Jan 7, 2022

@jkotas

This breaking 100% of jobs. Can we do a simple full revert of the offending change to unblock with high-confidence?

Ok, make sense. This PR is now a full revert.

Copy link
Member

@radical radical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the jobs pass

@jkotas
Copy link
Member

jkotas commented Jan 7, 2022

Merging to unblock CI

@jkotas jkotas merged commit ef49cd0 into dotnet:main Jan 7, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Feb 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants