Skip to content

Fix running WASM tests locally on Windows #63334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

maraf
Copy link
Member

@maraf maraf commented Jan 4, 2022

Set BROWSER_PATH variable only when HELIX_CORRELATION_PAYLOAD variable is set.

Fixes change in the #62779.

Set BROWSER_PATH variable only when HELIX_CORRELATION_PAYLOAD variable is set.

Fixes change in the dotnet#62779.
@maraf maraf added arch-wasm WebAssembly architecture area-Build-mono labels Jan 4, 2022
@maraf maraf added this to the 7.0.0 milestone Jan 4, 2022
@maraf maraf requested a review from pavelsavara January 4, 2022 12:12
@maraf maraf self-assigned this Jan 4, 2022
@ghost
Copy link

ghost commented Jan 4, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Set BROWSER_PATH variable only when HELIX_CORRELATION_PAYLOAD variable is set.

Fixes change in the #62779.

Author: maraf
Assignees: maraf
Labels:

arch-wasm, area-Build-mono

Milestone: 7.0.0

@maraf
Copy link
Member Author

maraf commented Jan 4, 2022

/azp run runtime-manual

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@maraf maraf merged commit cab2fd8 into dotnet:main Jan 5, 2022
@maraf maraf deleted the WasmFixLocalTestsRun branch January 5, 2022 08:00
@ghost ghost locked as resolved and limited conversation to collaborators Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants