Mark Regex source generator Go override as SkipLocalsInit if possible #63277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can have so many locals that zero-initing is measurable.
stephentoub
added
area-System.Text.RegularExpressions
tenet-performance
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions Issue DetailsIt can have so many locals that zero-initing is measurable.
|
joperezr
reviewed
Jan 3, 2022
| @@ -174,6 +174,8 @@ private static ImmutableArray<Diagnostic> EmitRegexMethod(IndentedTextWriter wri | |||
| return ImmutableArray.Create(Diagnostic.Create(DiagnosticDescriptors.LimitedSourceGeneration, rm.MethodSyntax.GetLocation())); | |||
| } | |||
|
|
|||
| bool allowUnsafe = compilation.Options is CSharpCompilationOptions { AllowUnsafe: true }; | |||
There was a problem hiding this comment.
if all we use from compilation is this check, is it better to just pass the bool from the generator or do you expect us to use the Compilation object for something else?
There was a problem hiding this comment.
As long as we're passing something, seemed like we might as well pass around the Compilation in case we need anything more from it later.
joperezr
approved these changes
Jan 3, 2022
I don't believe it's relevant to dynamic methods. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can have so many locals that zero-initing is measurable.