Parse compiler version in init-compiler.sh #63126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ghost
added
the
community-contribution
|
cc @gbalykov, @jkoritzinsky (still looking into the next tizen arm64 issue Gleb found with |
am11
force-pushed
the
feature/native/build-configs
branch
from
efd941f to
914319e
Compare
am11
force-pushed
the
feature/native/build-configs
branch
2 times, most recently
from
2dda175 to
b21aa83
Compare
When user passes versioned native compiler argument such as `-clang10.1` or `-gcc9.2` to the top-level `:/build.sh`, `:/eng/build.sh` transforms that to msbuild property called `<Compiler>` with raw/unprocessed value. In coreclr, libs, corehost and tests partitions, we end up calling `:/eng/native/build-commons.sh`, which slices the compiler name, major and minor versions, then calls `:/eng/native/gen-buildsys.sh` with individual components. That is just a pass-thru script for the final `:/eng/common/native/init-compiler.sh`, where those arguments are actually used. In `mono.proj` and `NativeExports.csproj`, we do not use `build-commons` script, but instead, invoke `init-compiler.sh` directly with the raw `<Compiler>` property. That causes an error when versioned native compiler is specified on the command line. This PR fixes this issue by pushing version parsing code into `init-compiler.sh` so all its consumers get the same behavior.
am11
force-pushed
the
feature/native/build-configs
branch
from
b21aa83 to
a3bcab5
Compare
jkotas
approved these changes
Dec 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When user passes versioned native compiler argument such as
-clang10.1or-gcc9.2to the top-level:/build.sh,:/eng/build.shtransforms that to msbuild property called<Compiler>with raw/unprocessed value.In coreclr, libs, corehost and tests partitions, we end up calling
:/eng/native/build-commons.sh, which slices the compiler name, majorand minor versions, then calls
:/eng/native/gen-buildsys.shwithindividual components. That is just a pass-thru script for the final
:/eng/common/native/init-compiler.sh, where those arguments areactually used.
In
mono.projandNativeExports.csproj, we do not usebuild-commonsscript, but instead, invokeinit-compiler.shdirectlywith the raw
<Compiler>property. That causes an error when versionednative compiler is specified on the command line.
This PR fixes the issue by pushing version parsing code into
init-compiler.shso all its consumers get the same behavior.Contributes to #63122.