Skip to content

Make copynative use nested msbuild out-of-proc executions #62404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2021

Conversation

trylek
Copy link
Member

@trylek trylek commented Dec 4, 2021

I recently noticed that the copynative step often takes an
excessive amount of time (up to 20 minutes). I tracked this down
to a deficiency caused by my summer cleanup of the test build
scripts - in the copynative step we should also use out-of-proc
msbuild executions for the individual test groups otherwise msbuild
chokes on the huge number of properties and slows down dramatically.

Thanks

Tomas

I recently noticed that the copynative step often takes an
excessive amount of time (up to 20 minutes). I tracked this down
to a deficiency caused by my summer cleanup of the test build
scripts - in the copynative step we should also use out-of-proc
msbuild executions for the individual test groups otherwise msbuild
chokes on the huge number of properties and slows down dramatically.

Thanks

Tomas
@ghost
Copy link

ghost commented Dec 4, 2021

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

I recently noticed that the copynative step often takes an
excessive amount of time (up to 20 minutes). I tracked this down
to a deficiency caused by my summer cleanup of the test build
scripts - in the copynative step we should also use out-of-proc
msbuild executions for the individual test groups otherwise msbuild
chokes on the huge number of properties and slows down dramatically.

Thanks

Tomas

Author: trylek
Assignees: -
Labels:

area-Infrastructure-coreclr

Milestone: -

Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's interesting that we never seemed to hit the OOM issues with these projects. Nice find!

@trylek trylek merged commit d5d5587 into dotnet:main Dec 4, 2021
@trylek trylek deleted the CopyNativeFix branch December 4, 2021 22:56
@ghost ghost locked as resolved and limited conversation to collaborators Jan 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants