Skip to content

Avoid closure for GetOrAdd #62317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2021
Merged

Avoid closure for GetOrAdd #62317

merged 1 commit into from
Dec 3, 2021

Conversation

meziantou
Copy link
Contributor

Description

Use the parameter of the lambda instead of creating a closure

@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-System.Data labels Dec 3, 2021
@ghost
Copy link

ghost commented Dec 3, 2021

Tagging subscribers to this area: @roji, @ajcvickers
See info in area-owners.md if you want to be subscribed.

Issue Details

Description

Use the parameter of the lambda instead of creating a closure

Author: meziantou
Assignees: -
Labels:

area-System.Data, community-contribution
Milestone: -

stephentoub
stephentoub approved these changes Dec 3, 2021
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks.

@meziantou meziantou marked this pull request as ready for review December 3, 2021 04:10
@danmoseley danmoseley merged commit 42224c6 into dotnet:main Dec 3, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jan 2, 2022
@meziantou meziantou deleted the closure branch January 28, 2022 22:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

Assignees
No one assigned
Labels
area-System.Data community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meziantou @stephentoub @danmoseley