-
Notifications
You must be signed in to change notification settings - Fork 5.1k
[wasm][debugger] View object attributes - DebugType=full #62278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tagging subscribers to this area: @thaystg Issue DetailsFix view object attributes from a class defined in an assembly with debugType = full. Fix discussion on: mono/mono#19942
|
} | ||
catch (BadImageFormatException) | ||
{ | ||
Console.WriteLine($"Warning: Unable to read debug information of: {Name} (use DebugType=Portable/Embedded)"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could log this using https://chromedevtools.github.io/devtools-protocol/tot/Log/ have it surface to the frontend
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how do you add a LogEntry with that though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You emit https://chromedevtools.github.io/devtools-protocol/tot/Log/#event-entryAdded from the proxy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I understood this is not supported by JSDebugger so I implemented using Runtime.consoleAPICalled
.
Co-authored-by: Ankit Jain <radical@gmail.com>
Keep peReader as an attribute as is recommended in the documentation. https://docs.microsoft.com/en-us/dotnet/api/system.reflection.metadata.pereaderextensions.getmetadatareader?view=net-6.0#System_Reflection_Metadata_PEReaderExtensions_GetMetadataReader_System_Reflection_PortableExecutable_PEReader_
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsFix view object attributes from a class defined in an assembly with debugType = full. Fix discussion on: mono/mono#19942 Adding the Runtime.consoleAPICalled, I couldn't use the Log.entryAdded didn't work on VS.
|
Fix view object attributes from a class defined in an assembly with debugType = full.
Fix discussion on: mono/mono#19942
Adding the Runtime.consoleAPICalled, I couldn't use the Log.entryAdded didn't work on VS.
in VS:

in Chrome:
