Skip to content

[wasm][debugger] View object attributes - DebugType=full #62278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 8, 2021

Conversation

thaystg
Copy link
Member

@thaystg thaystg commented Dec 2, 2021

Fix view object attributes from a class defined in an assembly with debugType = full.

Fix discussion on: mono/mono#19942

Adding the Runtime.consoleAPICalled, I couldn't use the Log.entryAdded didn't work on VS.

in VS:
image

in Chrome:
image

@thaystg thaystg requested a review from marek-safar as a code owner December 2, 2021 13:14
@ghost ghost added the area-Debugger-mono label Dec 2, 2021
@ghost
Copy link

ghost commented Dec 2, 2021

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix view object attributes from a class defined in an assembly with debugType = full.

Fix discussion on: mono/mono#19942

Author: thaystg
Assignees: -
Labels:

area-Debugger-mono

Milestone: -

}
catch (BadImageFormatException)
{
Console.WriteLine($"Warning: Unable to read debug information of: {Name} (use DebugType=Portable/Embedded)");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could log this using https://chromedevtools.github.io/devtools-protocol/tot/Log/ have it surface to the frontend

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do you add a LogEntry with that though?

Copy link
Member

@lewing lewing Dec 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I understood this is not supported by JSDebugger so I implemented using Runtime.consoleAPICalled.

radical
radical previously requested changes Dec 4, 2021
@ghost ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Dec 4, 2021
Co-authored-by: Ankit Jain <radical@gmail.com>
@ghost ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Dec 6, 2021
@thaystg thaystg requested a review from radical December 6, 2021 20:55
@radical radical added the arch-wasm WebAssembly architecture label Dec 7, 2021
@ghost
Copy link

ghost commented Dec 7, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix view object attributes from a class defined in an assembly with debugType = full.

Fix discussion on: mono/mono#19942

Adding the Runtime.consoleAPICalled, I couldn't use the Log.entryAdded didn't work on VS.

in VS:
image

in Chrome:
image

Author: thaystg
Assignees: -
Labels:

arch-wasm, area-Debugger-mono

Milestone: -

@thaystg thaystg merged commit 261a2dd into dotnet:main Dec 8, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jan 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants