Skip to content

Conversation

@eabdullin1
Copy link

Hello, add support for AlmaLinux for dotnet

@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-Infrastructure-libraries and removed community-contribution Indicates that the PR has been added by a community member labels Nov 30, 2021
@ghost
Copy link

ghost commented Nov 30, 2021

Tagging subscribers to this area: @safern
See info in area-owners.md if you want to be subscribed.

Issue Details

Hello, add support for AlmaLinux for dotnet

Author: eabdullin1
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@dnfadmin
Copy link

dnfadmin commented Nov 30, 2021

CLA assistant check
All CLA requirements met.

This way is better

Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@safern
Copy link
Member

safern commented Dec 3, 2021

Adjusting the area as I think this belongs to the host more than libraries infra.

Infra changes look good, they match what was done in: #59178

@eerhardt @vitek-karas @wfurt could you please help review?

@ghost
Copy link

ghost commented Dec 3, 2021

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

Hello, add support for AlmaLinux for dotnet

Author: eabdullin1
Assignees: -
Labels:

area-Host

Milestone: -

if [[ "${ID}" == "rhel" || "${ID}" == "rocky" ]]; then
# remove the last version digit
# for RHEL and its derivatives, remove the last version digit (if present)
if [[ "${ID}" == "rhel" || "${ID_LIKE}" =~ .*rhel.* ]]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this also affect centos and fedora?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition matches centos but not fedora.
After that value on centos is not affected by the line below, so it is only for distros which we have version / release policy like RHEL and are derivatives of that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, these PRs are not really needed, unless the distro really wants to create a "non-portable" release of .NET and provide some distro-specific packages.

https://dotnet.microsoft.com/download/dotnet/thank-you/sdk-6.0.100-linux-x64-binaries works for any glibc-based linux distro..

non-portable is only used by source builds for a long time now, elsewhere we all use portable binaries, so these PRs are less meaningful.

@eabdullin1
Copy link
Author

Are there any updates?

@vitek-karas
Copy link
Member

I know very little about this part of the Linux PAL in the host. @wfurt might have a better idea.
The code looks good, but I can't comment if it will work on the actual OS.

@eabdullin1
Copy link
Author

@wfurt Hello. Some updates?

@andrewlukoshko
Copy link

Are there any other dotnet projects repos where we should do the same?

@am11
Copy link
Member

am11 commented Dec 16, 2021

Distro specific RID (for non-portable build; i.e. ./build.sh -portable=false) in practice is only needed if a distro wants to provide and maintain distro nuget packages and that specific package is not usable on other distros.

This is a very rare case when a distro needs that kind of specificity. It was used by default in .NET Core v1.x. Starting from v2, official builds moved to portable build plan. Therefore, today in the wild, the commonly used installations are the generic linux or linux-musl ones for the supported architectures.

See the download page for binary installers: https://dot.net. Those installers can be built from dotnet/source-build (just don't pass portable=false legacy option).

In other words:

Add almalinux support

artifacts listed in table under https://github.com/dotnet/installer#installers-and-binaries should be functional without these changes.

@agocke
Copy link
Member

agocke commented Jan 31, 2022

Yeah, I'm not inclined to take this unless there's specific support needed for almalinux. Namely, what does the new RID provide that linux-x64 does not?

@danmoseley
Copy link
Member

@agocke should we close this then?

@trylek
Copy link
Member

trylek commented Jun 20, 2022

Closing for now as there's been no traffic on this PR for almost three months. Please feel free to reopen to follow up on this.

@trylek trylek closed this Jun 20, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jul 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants