-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Add almalinux support #62184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add almalinux support #62184
Conversation
|
Tagging subscribers to this area: @safern Issue DetailsHello, add support for AlmaLinux for dotnet
|
This way is better Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
|
Adjusting the area as I think this belongs to the host more than libraries infra. Infra changes look good, they match what was done in: #59178 @eerhardt @vitek-karas @wfurt could you please help review? |
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue DetailsHello, add support for AlmaLinux for dotnet
|
| if [[ "${ID}" == "rhel" || "${ID}" == "rocky" ]]; then | ||
| # remove the last version digit | ||
| # for RHEL and its derivatives, remove the last version digit (if present) | ||
| if [[ "${ID}" == "rhel" || "${ID_LIKE}" =~ .*rhel.* ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this also affect centos and fedora?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The condition matches centos but not fedora.
After that value on centos is not affected by the line below, so it is only for distros which we have version / release policy like RHEL and are derivatives of that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, these PRs are not really needed, unless the distro really wants to create a "non-portable" release of .NET and provide some distro-specific packages.
https://dotnet.microsoft.com/download/dotnet/thank-you/sdk-6.0.100-linux-x64-binaries works for any glibc-based linux distro..
non-portable is only used by source builds for a long time now, elsewhere we all use portable binaries, so these PRs are less meaningful.
|
Are there any updates? |
|
I know very little about this part of the Linux PAL in the host. @wfurt might have a better idea. |
|
@wfurt Hello. Some updates? |
|
Are there any other dotnet projects repos where we should do the same? |
|
Distro specific RID (for non-portable build; i.e. This is a very rare case when a distro needs that kind of specificity. It was used by default in .NET Core v1.x. Starting from v2, official builds moved to portable build plan. Therefore, today in the wild, the commonly used installations are the generic linux or linux-musl ones for the supported architectures. See the download page for binary installers: https://dot.net. Those installers can be built from dotnet/source-build (just don't pass In other words:
artifacts listed in table under https://github.com/dotnet/installer#installers-and-binaries should be functional without these changes. |
|
Yeah, I'm not inclined to take this unless there's specific support needed for almalinux. Namely, what does the new RID provide that linux-x64 does not? |
|
@agocke should we close this then? |
|
Closing for now as there's been no traffic on this PR for almost three months. Please feel free to reopen to follow up on this. |
Hello, add support for AlmaLinux for dotnet