Skip to content

Fix mono debugger thread block when wait for attach #62175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 2, 2021

Conversation

srxqds
Copy link
Contributor

@srxqds srxqds commented Nov 30, 2021

fix: #62128

@srxqds srxqds requested a review from marek-safar as a code owner November 30, 2021 03:58
@ghost ghost added area-Debugger-mono community-contribution Indicates that the PR has been added by a community member labels Nov 30, 2021
@ghost
Copy link

ghost commented Nov 30, 2021

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

fix: #62128

Author: srxqds
Assignees: -
Labels:

area-Debugger-mono

Milestone: -

@srxqds srxqds changed the title Fix mono gc thread Fix mono debugger thread not set flags Nov 30, 2021
@srxqds srxqds changed the title Fix mono debugger thread not set flags Fix mono debugger thread block when wait for attach Nov 30, 2021
Copy link
Member

@lambdageek lambdageek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srxqds Could you also change MONO_REQ_GC_SAFE_MODE to MONO_REQ_GC_UNSAFE_MODE at the beginning of wait_for_attach.

@srxqds
Copy link
Contributor Author

srxqds commented Nov 30, 2021

@srxqds Could you also change MONO_REQ_GC_SAFE_MODE to MONO_REQ_GC_UNSAFE_MODE at the beginning of wait_for_attach.

done

@lambdageek lambdageek merged commit 7b0a6b5 into dotnet:main Dec 2, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jan 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Debugger-mono community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mono] call GC.Collect(); block the main thread won't resume
2 participants