Stabilize upgrade code and dependency key for host msi #61619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikolaMilosavljevic
added
the
Servicing-consider
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Member
Author
|
Will update this PR with a change to bring new Arcade package, once it's built: dotnet/arcade#8183 |
Member
Author
|
I've updated the Arcade package (Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk). This PR can now be merged, once I get the approving review and it finishes building. @ericstj, @joeloff, @danmoseley - are there any concerns with approving this? |
Member
|
no concerns on my side, if its a necessary part of the work. |
joeloff
approved these changes
Nov 16, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stable upgrade codes and dependency key to allow proper msi upgrade experience.
We are using values from latest servicing release (5.0.12).