Skip to content

[release/6.0] [HTTP/3] Fixed stress #60723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 15, 2021
Merged

Conversation

antonfirsov
Copy link
Member

@antonfirsov antonfirsov commented Oct 21, 2021

Manual backport of #60364 to release/6.0

This is a test-only change updating msquic for HttpStress so we can run linux tests again on release/6.0.

/cc @ManickaP

Customer Impact

We need stress tests to assure the quality of the HTTP stack in .NET 6.0.

Testing

CI run should show if the build error is gone.

Risk

None.

@ghost ghost added the area-System.Net.Http label Oct 21, 2021
@ghost
Copy link

ghost commented Oct 21, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Manual backport of #60364 to release/6.0

This is a test-only change updating msquic for HttpStress so we can run linux tests again on release/6.0.

Customer Impact

We need stress tests to assure the quality of the HTTP stack in .NET 6.0.

Testing

CI run should show if the build error is gone.

Risk

None.

Author: antonfirsov
Assignees: -
Labels:

area-System.Net.Http

Milestone: -

@antonfirsov
Copy link
Member Author

/azp run runtime-libraries stress-http

@antonfirsov antonfirsov requested a review from ManickaP October 21, 2021 18:23
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@antonfirsov antonfirsov requested a review from a team October 21, 2021 18:23
Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, you're faster than me.

@antonfirsov
Copy link
Member Author

@danmoseley @karelz we need to merge this and #60682 before 6.0 GA 4pm PST Friday!

@mmitche
Copy link
Member

mmitche commented Oct 21, 2021

@danmoseley @karelz we need to merge this and #60682 before 6.0 GA 4pm PST Friday!

If this is test-only is it required for GA?

@lewing lewing added this to the 6.0.0 milestone Oct 21, 2021
@lewing lewing added the Servicing-consider Issue for next servicing release review label Oct 21, 2021
@karelz
Copy link
Member

karelz commented Oct 21, 2021

I agree that 6.0 servicing should be sufficient - whichever is easier for 6.0 shipping.

@danmoseley danmoseley added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) and removed Servicing-consider Issue for next servicing release review labels Oct 22, 2021
@danmoseley
Copy link
Member

Does'nt need servicing-consider as it's test/infra work. It does need to wait for branch to open that's all

@jeffhandley jeffhandley modified the milestones: 6.0.0, 6.0.x Nov 22, 2021
@karelz karelz removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Nov 22, 2021
@karelz
Copy link
Member

karelz commented Nov 22, 2021

Removing NO MERGE, as it now can be merged.
@danmoseley does it need Approval label to be merged? Or how does it work for test-only changes?

@karelz
Copy link
Member

karelz commented Nov 30, 2021

@danmoseley ping?

@dotnet dotnet deleted a comment from azure-pipelines bot Dec 15, 2021
@safern
Copy link
Member

safern commented Dec 15, 2021

/azp run runtime-libraries stress-http

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@antonfirsov
Copy link
Member Author

antonfirsov commented Dec 15, 2021

@safern note that neither this PR nor #60682 is sufficient alone to fix HttpStress, we need both. (The original PR-s worked separately because they reacted to different upstream changes that came at different times.)

@safern
Copy link
Member

safern commented Dec 15, 2021

Thanks for the clarification. I will then merge regardless of the status of that build.

@safern safern merged commit df64b93 into release/6.0 Dec 15, 2021
@safern safern deleted the antonfirsov/backport-60364 branch December 15, 2021 19:30
@ghost ghost locked as resolved and limited conversation to collaborators Jan 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants