Skip to content

Fix intermittent failure in DllImportGenerator unit tests when resolving assemblies #60722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2021

Conversation

elinor-fung
Copy link
Member

Since the tests run in parallel, we could end up clearing out the variable for redirecting the package cache while it was still needed by another test.

Fixes #60706

@steveisok
Copy link
Member

On the mono windows x64 leg (staging pipeline), we're getting a whole bunch of these in the DllImportGenerator tests:

NuGet.Protocol.Core.Types.FatalProtocolException : Unable to load the service index for source https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json.
---- System.Net.Http.HttpRequestException : Unknown error (0xffffffff) (pkgs.dev.azure.com:443)
-------- System.Net.Sockets.SocketException : Unknown error (0xffffffff)

@elinor-fung
Copy link
Member Author

I suspect that is a manifestation of #53281. We can disable these unit tests for mono on Windows.

@elinor-fung elinor-fung merged commit d16fffd into dotnet:main Oct 21, 2021
@elinor-fung elinor-fung deleted the fix60706 branch October 21, 2021 21:59
@ghost ghost locked as resolved and limited conversation to collaborators Nov 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.