[release/6.0][wasm] Change dotnet.wasm link optimization #60632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet#60349 When we switched to Emscripten 2.0.21, we stopped using deprecated `--llvm-opts 2` option. This caused unwanted performance degradation. Switching to `-O2` get us similar performance as with `--llvm-opts`. Blazor wasm test app `Time to first UI` benchmark times: branch/commit link option time dotnet.wasm size --------------------+------------+--------+----------------- release/6.0 92ff02 -Oz 491ms 2,430,639 release/6.0 92ff02 -O2 457ms 2,474,518 release/6.0 92ff02 -O3 444ms 2,555,824
lambdageek
changed the title
Member
|
we're going to let this bake for a bit before we take it in servicing |
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsContext: #60349 When we switched to Emscripten 2.0.21, we stopped using deprecated Blazor wasm test app
|
leecow
added
Servicing-approved
radical
reviewed
Nov 3, 2021
Contributor
|
@marek-safar @radical can you review this one ? |
marek-safar
approved these changes
Nov 10, 2021
lewing
approved these changes
Nov 10, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #60349
When we switched to Emscripten 2.0.21, we stopped using deprecated
--llvm-opts 2option. This caused unwanted performance degradation.Switching to
-O2get us similar performance as with--llvm-opts.Blazor wasm test app
Time to first UIbenchmark times:Customer Impact
Fixes a startup time regression for blazorwasm between .NET 5 an .NET 6 by a reverting compiler option change that was accidentally introduced as part of other build changes.
Testing
Manual and Automated
Regression
Yes, startup time regression.
Risk
Low, switch to compiler options we're using in main.