[release/5.0] Make upgrade install new host first, then uninstall old #60325
Conversation
This should preserve the ordering of PATH, since the old MSI will never remove its entry.
|
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer Issue DetailsBackport of #60307 to release/5.0 Customer ImpactCustomers installing upgrades of .NET 6.0 observe the entry for dotnet will move to the end of the PATH variable, often resulting in x86 dotnet being first and winning. TestingManual build of host and upgrade testing. I've tested upgrade scenarios where 5.0 x86 + x64 is installed. Upgrade to 6.0 x64 without the fix will move x64 PATH to end. Once fix is in place we don't move PATH entry. RiskLow. This doesn't change installer behavior like some of the other options we considered. The change is scoped to only the host MSI
|
|
The drawing test failures are fixed by #60201 |
|
I think @ericstj i jumped the gun here as there were no failures related to the change. I will keep a look out for the arcade update pr. Hopefully i didnt cause any hiccup here. |
|
That's ok. This was approved over mail. We need to merge all the others and flow arcade. |
ghost
locked as resolved and limited conversation to collaborators
3 participants
Backport of #60307 to release/5.0
Requires dotnet/arcade#8029
Customer Impact
Customers installing upgrades of .NET 5.0 observe the entry for dotnet will move to the end of the PATH variable, often resulting in x86 dotnet being first and winning.
Testing
Manual build of host and upgrade testing. I've tested upgrade scenarios where 5.0 x86 + x64 is installed. Upgrade to 6.0 x64 without the fix will move x64 PATH to end. Once fix is in place we don't move PATH entry.
Risk
Low. This doesn't change installer behavior like some of the other options we considered. The change is scoped to only the host MSI