[reflection] Return n2m wrapper from RuntimeMethodHandle.GetFunctionPointer #60200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @BrzVlad Issue Detailsfor functions marked with Contributes to #59815
|
|
@BrzVlad can you take a look. In particular do we care about a (somewhat expensive) attribute check in |
…ointer for functions marked with UnmanagedCallersOnlyAttribute, return a pointer to the n2m wrapper for calls to GetFunctionPointer Contributes to dotnet#59815
lambdageek
force-pushed
the
fix-unmanaged-getfunctionpointer
branch
from
8c8647e to
4b725ec
Compare
BrzVlad
approved these changes
Oct 11, 2021
jkoritzinsky
added a commit
to jkoritzinsky/runtime
that referenced
this pull request
Oct 11, 2021
Now that dotnet#59815 and dotnet#60200 are merged, the DllImportGenerator tests pass on Mono in desktop form factors (where hostfxr and hostpolicy exist).
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for functions marked with
UnmanagedCallersOnlyAttribute, return a pointer to the n2m wrapper for calls toGetFunctionPointerContributes to #59815