[release/6.0-rc2][wasm][debugger] Fix reuse buffer #59775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsBackport of #59773 to release/6.0 Customer ImpactDebugger is not working from VS. TestingTested manually on Blazor RiskLow risk, it's reseting the
|
lewing
approved these changes
Sep 29, 2021
lewing
changed the title
Member
|
Retargeted to rc2 and approved per email discussion. |
lewing
added
Servicing-approved
Member
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
cc @Anipik |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #59773 to release/6.0
When the wasm linear memory has to grow it invalidates existing views into the heap. To avoid this issue make sure to always create a new view into the heap for the debugger command immediately before use.
Customer Impact
Debugging will eventually fail once the runtime allocates enough memory to require growing the Wasm memory buffer.
Testing
Tested manually on Blazor
Tested on debugger-tests
Risk
Low risk, it's reseting the
_debugger_heap_bytesalways before the usage to avoid using an invalid pointer in the case that Module.HEAPU8.buffer is reallocated.