You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For long time in ARM, we have a workaround to add BBJ_ALWAYS in fgEnterBlks so we do not remove that block and convert the finally into BBF_RETLESS_CALL. For that reason, we would not iterate over such blocks while computing the dominance reachability . I double checked and we have enough checks to prevent that from happening. So there is no use of special handling of this scenario during dominance calculation.
For long time in ARM, we have a workaround to add BBJ_ALWAYS in fgEnterBlks so we do not remove that block and convert the finally into BBF_RETLESS_CALL. For that reason, we would not iterate over such blocks while computing the dominance reachability . I double checked and we have enough checks to prevent that from happening. So there is not use of special handling of this scenario during dominance calculation where we would skip iterating these blocks leading to hitting an assert.
ghost
locked as resolved and limited conversation to collaborators
Nov 3, 2021
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ghost
added
the
area-CodeGen-coreclr
kunalspathak
force-pushed
the
retless
branch
from
For long time in ARM, we have a workaround to add
BBJ_ALWAYSinfgEnterBlksso we do not remove that block and convert the finally intoBBF_RETLESS_CALL. For that reason, we would not iterate over such blocks while computing the dominance reachability . I double checked and we have enough checks to prevent that from happening. So there is no use of special handling of this scenario during dominance calculation.Fixes: #59298