Work around for forbidden "Roslyn4.0" in test name on Android #59263
Conversation
Android apk names must be valid Java class names, and It is forbidden in Java for a class name component to have a leading numeric digit. So whilst "net.dot.foo3_1" is legal, "net.dot.foo3.1" is illegal. Use a Regex to detect and rewrite all cases of this in AndroidAppBuilder
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
directhex
requested review from
mdh1418 and
steveisok
and removed request for
mdh1418
|
Tagging subscribers to 'arch-android': @steveisok, @akoeplinger Issue DetailsAndroid apk names must be valid Java class names, and It is forbidden in Java for a class name component to have a leading numeric digit. So whilst "net.dot.foo3_1" is legal, "net.dot.foo3.1" is illegal. Use a Regex to detect and rewrite all cases of this in AndroidAppBuilder
|
|
/backport to release/6.0-rc2 |
|
Started backporting to release/6.0-rc2: https://github.com/dotnet/runtime/actions/runs/1246965180 |
|
@directhex backporting to release/6.0-rc2 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Work around for forbidden "Roslyn4.0" in test name on Android
Applying: Fix typos
Applying: Disable failing Catalyst test
Using index info to reconstruct a base tree...
M src/libraries/tests.proj
Falling back to patching base and 3-way merge...
Auto-merging src/libraries/tests.proj
CONFLICT (content): Merge conflict in src/libraries/tests.proj
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0003 Disable failing Catalyst test
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
…#59263) Android apk names must be valid Java class names, and It is forbidden in Java for a class name component to have a leading numeric digit. So whilst "net.dot.foo3_1" is legal, "net.dot.foo3.1" is illegal. Use a Regex to detect and rewrite all cases of this in AndroidAppBuilder
#59281) Android apk names must be valid Java class names, and It is forbidden in Java for a class name component to have a leading numeric digit. So whilst "net.dot.foo3_1" is legal, "net.dot.foo3.1" is illegal. Use a Regex to detect and rewrite all cases of this in AndroidAppBuilder
ghost
locked as resolved and limited conversation to collaborators
|
/backport to foo |
|
Started backporting to foo: https://github.com/dotnet/runtime/actions/runs/1425719388 |
|
@directhex an error occurred while backporting to foo, please check the run log for details! Error: @directhex is not a repo collaborator, backporting is not allowed. |
|
/backport to foo |
|
Started backporting to foo: https://github.com/dotnet/runtime/actions/runs/1425730295 |
|
@directhex an error occurred while backporting to foo, please check the run log for details! Error: The specified backport target branch foo wasn't found in the repo. |
ghost
locked as resolved and limited conversation to collaborators
2 participants
Android apk names must be valid Java class names, and It is forbidden in Java for a class name component to have a leading numeric digit. So whilst "net.dot.foo3_1" is legal, "net.dot.foo3.1" is illegal. Use a Regex to detect and rewrite all cases of this in AndroidAppBuilder