Skip to content

Conversation

kant2002
Copy link
Contributor

Closes #51112

@ghost ghost added area-Meta community-contribution Indicates that the PR has been added by a community member labels Sep 16, 2021
@danmoseley
Copy link
Member

@eerhardt can you confirm these are all dead? I assume so and I'm surprised we didn't delete them way back.

@eerhardt
Copy link
Member

The ILLinker doesn't read these files at all. The only thing I'm aware of that reads them is the UWP tooling, which we've removed support for in this repo.

cc @MichalStrehovsky

@MichalStrehovsky
Copy link
Member

Yup. These might have been useful for OOB assemblies since .NET Native devs can reference NuGet packages with these, but the support for embedding the RD.XML was pulled out in 2019 along will all the .NET Native testing. They're dead since. If we were testing with .NET Native like we test with .NET Framework these would be useful but we don't do that.

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the help, @kant2002!

@danmoseley danmoseley merged commit 5588f94 into dotnet:main Sep 16, 2021
@kant2002 kant2002 deleted the kant/remove-rdxml branch September 17, 2021 07:11
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Meta community-contribution Indicates that the PR has been added by a community member
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Remove usused rd.xml files
4 participants