Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Sep 14, 2021

Backport of #58651 to release/6.0

Fixes #54573

Enables arcade powered source build leg in PRs as well as for internal builds. This leg will publish sourcebuild.Intermediate.* packages which could be used in upstack repos in their respective sourcbuild legs.

This change also fixes the bug where the native msquic.dll was being wrongly being binplaced.

/cc @Anipik

Customer Impact

This will allow us to catch any source build related failures early on.

Testing

Its an additional CI leg which tests the source build.

Risk

low.

@ghost
Copy link

ghost commented Sep 14, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@Anipik Anipik changed the title [release/6.0] Use arcade power source build infra [Tell-mode][release/6.0] Use arcade power source build infra Sep 14, 2021
@ghost
Copy link

ghost commented Sep 15, 2021

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #58651 to release/6.0

Fixes #54573

Enables arcade powered source build leg in PRs as well as for internal builds. This leg will publish sourcebuild.Intermediate.* packages which could be used in upstack repos in their respective sourcbuild legs.

This change also fixes the bug where the native msquic.dll was being wrongly being binplaced.

/cc @Anipik

Customer Impact

This will allow us to catch any source build related failures early on.

Testing

Its an additional CI leg which tests the source build.

Risk

low.

Author: github-actions[bot]
Assignees: -
Labels:

area-Infrastructure

Milestone: -

@danmoseley
Copy link
Member

@lewing lots of build breaks due to failing to access \artifacts\obj\WasmAppBuilder\Debug\net472\WasmAppBuilder.dll.

I will cross fingers and rerun again.

@ericstj
Copy link
Member

ericstj commented Sep 15, 2021

This introduced those failures. #58904

Thanks for the pointer @eerhardt

@Anipik Anipik merged commit c43facb into release/6.0 Sep 15, 2021
@eerhardt eerhardt deleted the backport/pr-58651-to-release/6.0 branch September 15, 2021 15:00
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants